Update macosx-version-min to 11 aka 'Big Sur' #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
Shelnutt2,
ihnorton,
awenocur,
teo-tsirpanis,
KiterLuc and
eric-hughes-tiledb
|
This pull request has been linked to Shortcut Story #38140: Switch macOS builds (for R use) to |
teo-tsirpanis
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows discussions both internally at TileDB and on the r-package-devel list; the stated minimum for macOS builds (per e.g. https://mac.r-project.org/) is now version 11 ('Big Sur') and old-rel builds on x86_64 appear to be quietly suspended.
Version 11 works for us as it allows for
std::filesystem. The corresponding change in Core has not (yet ?) been backported to release-2.19 but the R package can use it either way.