Skip to content

Commit

Permalink
Print values for tiledb_schema_get_types() and `tiledb_schema_get_n…
Browse files Browse the repository at this point in the history
…ames()` (#807)

* Print values for `tiledb_schema_get_types()` and `tiledb_schema_get_names()`

* DESCRIPTION too

* Apply suggestions from code review

Co-authored-by: Paul Hoffman <[email protected]>

---------

Co-authored-by: Paul Hoffman <[email protected]>
  • Loading branch information
johnkerl and mojaveazure authored Feb 18, 2025
1 parent b08b4c6 commit aeb0388
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.31.0.2
Version: 0.31.0.3
Title: Modern Database Engine for Complex Data Based on Multi-Dimensional Arrays
Authors@R: c(
person("TileDB, Inc.", role = c("aut", "cph")),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Allow `parse_query_condition()` to work on dimensions when an array is passed
* Add `tiledb_vfs_copy_dir()`, a wrapper for the `vfs_copy_dir()` function
* Print values for `tiledb_schema_get_types()` and `tiledb_schema_get_names()` [#805](https://github.com/TileDB-Inc/TileDB-R/issues/805)

# tiledb 0.31.0

Expand Down
4 changes: 2 additions & 2 deletions R/ArraySchema.R
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ tiledb_schema_get_names <- function(sch) {
attrs <- tiledb::attrs(sch)
attrnames <- unname(sapply(attrs, function(a) libtiledb_attribute_get_name(a@ptr)))

allnames <- c(dimnames, attrnames)
return(c(dimnames, attrnames))
}

##' Get all Dimension and Attribute Types
Expand All @@ -612,7 +612,7 @@ tiledb_schema_get_types <- function(sch) {
attrs <- tiledb::attrs(sch)
attrtypes <- unname(sapply(attrs, function(a) libtiledb_attribute_get_type(a@ptr)))

alltypes <- c(dimtypes, attrtypes)
return(c(dimtypes, attrtypes))
}

##' Get Dimension or Attribute Status
Expand Down

0 comments on commit aeb0388

Please sign in to comment.