Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test that randomly fails on linux-64 tiledb-py-feedstock Azure builds #2166

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

jdblischak
Copy link
Contributor

@jdblischak jdblischak commented Feb 26, 2025

This test regularly fails on linux-64 tiledb-py-feedstocks builds (TileDB-Inc/conda-forge-nightly-controller#167, TileDB-Inc/conda-forge-nightly-controller#170, conda-forge/tiledb-py-feedstock#256), but we have been unable to reproduce it elsewhere (even when using build-locally.py to locally mimic the conda-forge feedstock setup in a Docker container).

This PR skips the problematic test when the env var CONDA_BUILD is set to 1 (set by conda-build). I tested this branch in my feedstock fork to confirm the flaky test was skipped:

tiledb/tests/test_multi_index-hp.py::TestMultiIndexPropertySparse::test_multi_index_two_way_query SKIPPED [ 44%]

We should merge this PR only once we are done troubleshooting the feedstock test failure, eg using libSegFault (TileDB-Inc/conda-forge-nightly-controller#170 (comment)).

Closes TileDB-Inc/conda-forge-nightly-controller#170

@jdblischak
Copy link
Contributor Author

I confirmed that the test was run and passed, eg here for the win-64 py313 build:

D:\a\TileDB-Py\TileDB-Py\tiledb\tests\test_multi_index-hp.py::TestMultiIndexPropertySparse::test_multi_index_two_way_query PASSED [ 63%]

However, all the tests are failing because of an access/authentication issue. I assume this is because I opened the PR from a branch from a fork. I don't have write-access to this repo, so I can't push an internal branch.

=========================== short test summary info ===========================
FAILED D:\a\TileDB-Py\TileDB-Py\tiledb\tests\test_cloud.py::CloudTest::test_save_and_open_array_from_cloud - tiledb.libtiledb.TileDBError: [TileDB::REST] Error: Invalid array URI for REST service; expected format is 'tiledb://<namespace>/<array-name>' or 'tiledb://<namespace>/<array-uri>'.
= 1 failed, 1002 passed, 19 skipped, 7 xfailed, 1 warning in 217.31s (0:03:37) =

But given how innocuous this PR is, I hope that we can merge it as is without worrying about this authentication error.

@kounelisagis kounelisagis self-requested a review February 27, 2025 00:35
Copy link
Member

@kounelisagis kounelisagis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kounelisagis
Copy link
Member

I confirmed that the test was run and passed, eg here for the win-64 py313 build:

D:\a\TileDB-Py\TileDB-Py\tiledb\tests\test_multi_index-hp.py::TestMultiIndexPropertySparse::test_multi_index_two_way_query PASSED [ 63%]

However, all the tests are failing because of an access/authentication issue. I assume this is because I opened the PR from a branch from a fork. I don't have write-access to this repo, so I can't push an internal branch.

=========================== short test summary info ===========================
FAILED D:\a\TileDB-Py\TileDB-Py\tiledb\tests\test_cloud.py::CloudTest::test_save_and_open_array_from_cloud - tiledb.libtiledb.TileDBError: [TileDB::REST] Error: Invalid array URI for REST service; expected format is 'tiledb://<namespace>/<array-name>' or 'tiledb://<namespace>/<array-uri>'.
= 1 failed, 1002 passed, 19 skipped, 7 xfailed, 1 warning in 217.31s (0:03:37) =

But given how innocuous this PR is, I hope that we can merge it as is without worrying about this authentication error.

You are right, this is an authentication issue because of forking.

@kounelisagis kounelisagis merged commit 1b90a9f into TileDB-Inc:main Feb 27, 2025
2 of 22 checks passed
@jdblischak jdblischak deleted the skip-flaky-test-in-feedstock branch February 27, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly feedstock build failed
2 participants