Update requirements_dev.txt to improve contributor workflow #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
commented
May 4, 2023
| @@ -44,5 +51,5 @@ Thanks for your interest in TileDB-Py. The notes below give some pointers for fi | |||
|
|
|||
| - Make changes locally, then rebuild with `python setup.py develop [--tiledb=<>]` | |||
| - Make sure to run `pytest` to verify changes against tests (add new tests where applicable). | |||
| - Execute the tests as `pytest tiledb` from the top-level directory or `pytest` in the `tiledb/` directory. | |||
| - Execute the tests as `python -m pytest tiledb` from the top-level directory or `python -m pytest` in the `tiledb/` directory. | |||
There was a problem hiding this comment.
If you don't do python -m you can potentially get path conflict issues.
|
Can we get this stanza into a dev section in |
johnkerl
reviewed
May 4, 2023
|
Should be 2 commands after #1988: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that you can get from cloning the repo to running the tests in only 3 commands:
The version numbers that I put in are just the latest version, as I am not sure what the correct minimum version is.