add memory clean up on gochannel subscribe topics when they no longer have any more subscribers #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have any subscribers This allows publishing and subscribing to narrowly focused topics that include random data like UUIDs in topic name. Without this change, memory usage will grow indefinitely in a long-running service as the map grows larger and larger with keys pointing to empty slices.
dkotik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows publishing and subscribing to narrowly focused topics that include random data like UUIDs in topic name. Without this change, memory usage will grow indefinitely in a long-running service as the map grows larger and larger with keys pointing to empty slices.
The change is small, but it allows using Watermill Gochannel like NATS - having a topic per HTTP request, for example.