commit offset explicitly when AutoCommit is disabled and added Test Code for Manual Commit

[tjnet]

context

• We should commit offset explicitly then AutoCommit disabled by donmikel · Pull Request #13 · ThreeDotsLabs/watermill-kafka
  • I took over his pull request and added test code for it.

I followed his suggestion

Can you add a test for that case in that file: https://github.com/ThreeDotsLabs/watermill-kafka/blob/master/pkg/kafka/pubsub_test.go

I think that it is not needed to run entire tests.TestPubSub. I think that it should be enough to use TestPublishSubscribe from the test suite.

could you confirm when you have time?

[voodoo-dn]

@roblaszczak Hi. We disabled autocommit and experienced error which is fixed in this PR. Is it real to merge it? It's very necessary for us. Thanks.

[Exxon1800]

Hi, I was wondering, is this feature still going to be implemented? This feature would be really useful for the project I'm working on. Thanks so far!

[roblaszczak]

it took some time, but it's finally green 🎉

for the record, what helped was re-building docker-compose #37

additionally, setting Consumer.Offsets.AutoCommit.Enable slows subscribing a lot, so I added option to run tests with less messages: 47e6b78

[roblaszczak]

thanks @tjnet for contribution!