Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: CEF128+: Avoid crash on OnProtocolExecution #262

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Jan 6, 2025

Which issue(s) this PR fixes:

https://github.com/ThinBridge/Chronos-SG/issues/305

What this PR does / why we need it:

This is a Chronos side temporary patch for chromiumembedded/cef#3851.

Using CefBrowser->StopLoad() with allow_os_execution = true causes a crash on CEF128+.
In order to avoid the crash, specifying allow_os_execution = false on CEF128+, but this blocks to execute applications installed in OS. E.g. Zoom application for Windows.

We should specify allow_os_execution = true after the bug on CEF128+ is fixed.

How to verify the fixed issue:

  • Access a Zoom meeting page URL.
    • Confirm that Chronos does not crash.
    • Confirm that a dialog to confirm to open OS application is not displayed.
  • Click the "Launch meeting" ("ミーティングを起動する") button
    • Confirm that Chronos does not crash.
    • Confirm that nothing happens
  • Click the "Join from your browser" ("ブラウザから参加") link
    • Confirm that a Zoom meeting room is displayed.
  • Access a Teams meeting page URL.
    • Confirm that Chronos does not crash.
  • Click the "Join on the Teams app" ("Teams アプリで参加する") button
    • Confirm that Chronos does not crash.
    • Confirm that nothing happens
  • Click the "Continue on this browser" ("このブラウザーで続ける") link
    • Confirm that a Teams meeting room is displayed.

Using CefBrowser->StopLoad() with allow_os_execution = true causes a crash on CEF128+.
chromiumembedded/cef#3851

In order to avoid the crash, specifying allow_os_execution = false on CEF128+, but
this blocks to execute applications installed in OS. E.g. Zoom application for Windows.

We should specify allow_os_execution = true after the bug on CEF128+ is fixed.
@HashidaTKS HashidaTKS changed the title CEF128+: Avoid crash on OnProtocolExecution draft: CEF128+: Avoid crash on OnProtocolExecution Jan 6, 2025
@HashidaTKS HashidaTKS marked this pull request as draft January 6, 2025 03:00
@HashidaTKS HashidaTKS marked this pull request as ready for review January 8, 2025 05:38
@HashidaTKS HashidaTKS requested a review from kenhys January 8, 2025 05:40
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 3c125fa into master Jan 8, 2025
3 checks passed
@kenhys kenhys deleted the avoid-crash-on-OnProtocolExecution branch January 8, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants