draft: CEF128+: Avoid crash on OnProtocolExecution #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
https://github.com/ThinBridge/Chronos-SG/issues/305
What this PR does / why we need it:
This is a Chronos side temporary patch for chromiumembedded/cef#3851.
Using
CefBrowser->StopLoad()
withallow_os_execution = true
causes a crash on CEF128+.In order to avoid the crash, specifying
allow_os_execution = false
on CEF128+, but this blocks to execute applications installed in OS. E.g. Zoom application for Windows.We should specify
allow_os_execution = true
after the bug on CEF128+ is fixed.How to verify the fixed issue: