This repository was archived by the owner on Oct 25, 2025. It is now read-only.
Do not allow using more than one gem for cutting#214
Open
AgentK20 wants to merge 2 commits intoTheWinABagel:1.20from
Open
Do not allow using more than one gem for cutting#214AgentK20 wants to merge 2 commits intoTheWinABagel:1.20from
AgentK20 wants to merge 2 commits intoTheWinABagel:1.20from
Conversation
Author
|
Poke about this @TheWinABagel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an exploit where the user may place more than one gem in the gem cutting table and upgrade the entire stack to a higher tier. I'm not 100% that this is an exploit, but it seems pretty broken to me to be able to convert 64 tier 1 gems into 60 tier 5 gems, rather than the expected halving operation that is implied by documentation, but for my server at least I wanted to patch this.
Unfortunately I'm not the best at modding, so this is kind of a janky fix that works at the cost of requiring users to separate their gems into individual-item stacks before they are allowed to place them into the gem cutting table. Please let me know if there's a better way to do this.