Skip to content

Conversation

@moira-andrews
Copy link
Contributor

Helps with large localization regions so the database doesn't ingest all the galaxies and cause page loading issues. Can be reduced further.

@moira-andrews moira-andrews self-assigned this Nov 12, 2025
Copy link
Collaborator

@swyatt7 swyatt7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small variable name changes then should be good to go.

Comment on lines 181 to 184
if len(ii) > ngalaxtoshow:
n = ngalaxtoshow
else:
n = len(ii)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name n something more meaningful.

Also can you name ii something more meaningful as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, updated in most recent commit!

Copy link
Collaborator

@swyatt7 swyatt7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Barring anything from @cmccully, feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants