-
Notifications
You must be signed in to change notification settings - Fork 96
Adding attempts to readLine and state marker if radio module is unres… #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johanstokking
merged 24 commits into
TheThingsNetwork:master
from
savnik:feature/readline-timeout
Jan 14, 2019
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4629038
Adding attempts to readLine and state marker if radio module is unres…
savnik 0653d8d
Fix spacing around brackets
savnik 012e651
Adding attempts to TheTHingsNetwork.h
savnik 9693732
No need for else when if has return
savnik 77403c6
Set default in header file
savnik 2a1968e
decrement attempts
savnik 91d5b8b
Proposal to handle exception when RN module does not respond
savnik 2df5307
Changed variable name from radioModuleInvalidState to needsHardReset
savnik d4a6ce5
Added hardReset function with non-blocking delay. made needsHardReset…
savnik 72fc4f2
Updating documentation for hardreset
savnik 71e3d0a
Changed wording of unresponsive rn module in readline function
savnik 833ec1e
Spacing in if statement in readline function
savnik 0fc3bc2
Removing comment at readline function
savnik d74d17d
Fixed spelling mistake of millis in resetHard
savnik fe0c8ab
Replacing single qoute with double qoute to fix warning: character co…
savnik a0afabf
remove empty line
savnik 69ef443
Fixed missing (
savnik 896a8aa
moved adr parameter to reset and added parameter description for hard…
savnik 88c81a0
Spelling mistake
savnik 13b554f
Reformulated the non i/o blocking wait function to make it more under…
savnik 8c8cb8c
Updated the way while brackets are placed in resetHard
savnik 8ec0a25
Updated hardreset documentation to include initial pinmode setup
savnik a17f5e4
rewording of hardreset output pin config
savnik 87dacf4
Using delay(1000) instead of custom delay function to ensure that ESP…
savnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.