Fix esp-idf and IPv6 support by using plain UDP socket, drop Syslog library

[dwmw2]

It turns out to be fairly simple to just send the UDP packets directly, and the UDP socket handling can then be a whole lot more generic.

[chatziko]

Thanks for this PR, it works great with esp-idf!

However with arduino I get the following error:

src/esphome/components/syslog/syslog_component.cpp: In member function 'virtual void esphome::syslog::SyslogComponent::setup()':
src/esphome/components/syslog/syslog_component.cpp:65:72: error: 'IPPROTO_UDP' was not declared in this scope; did you mean 'IPPROTO_TCP'?
   65 |     this->socket_ = socket::socket(this->server.ss_family, SOCK_DGRAM, IPPROTO_UDP);
      |                                                                        ^~~~~~~~~~~
      |                                                                        IPPROTO_TCP

I'm using esphome 2024.9.0 with the following config:

external_components:
  - source: github://dwmw2/esphome_syslog@esp-ipv6-support
    components: [syslog]

syslog:
    ip_address: <redacted>
    port: 514

Any chance of making the code compatible with both arduino and esp-idf?

[dwmw2]

Hm, which platform is that on? I thought I'd tested it with Arduino for ESP32. I think there are some platforms where UDP isn't available directly in LwIP and we have to use the Arduino UDP as before, as I mentioned above. I'll have a look at making the change conditional.

[chatziko]

Oh, just realized that this was on a esp8266 device (not esp32). But there are still plenty of those out there :D

[leo-b]

IPPROTO_UDP is not defined on arduino for esp8266.
I managed to fix this by adding

#ifndef IPPROTO_UDP
#include <lwip/ip.h>
#define IPPROTO_UDP IP_PROTO_UDP
#endif

Maybe there is a better way but this works for me. (Also tested with esp-idf.)

[dwmw2]

I made it #ifdef USE_SOCKET_IMPL_LWIP_TCP; does that work for you?

[dwmw2]

And also, does that make it work or just make it build? The comment at esphome/esphome#4969 (comment) seems to suggest that it'll still just use TCP? Is it actually connecting to the syslog server over TCP?

[lucize]

so as it is right now esp8266 doesn't work, also verified that

#ifdef USE_SOCKET_IMPL_LWIP_TCP
#include <lwip/ip.h>
#define IPPROTO_UDP IP_PROTO_UDP
#endif

is in the source file

[barcar]

Thanks for this PR, it works great with esp-idf!

However with arduino I get the following error:

src/esphome/components/syslog/syslog_component.cpp: In member function 'virtual void esphome::syslog::SyslogComponent::setup()':
src/esphome/components/syslog/syslog_component.cpp:65:72: error: 'IPPROTO_UDP' was not declared in this scope; did you mean 'IPPROTO_TCP'?
   65 |     this->socket_ = socket::socket(this->server.ss_family, SOCK_DGRAM, IPPROTO_UDP);
      |                                                                        ^~~~~~~~~~~
      |                                                                        IPPROTO_TCP

I'm also seeing this on my older ESP8266 devices. Is there a fix for this?

[KrX3D]

works good with idf and arduino for me. thanks ;)