Add support for :otp_app
option in ConnGRPC.Pool for configuration loading
#20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team, thank you so much for package, we are trying to adopt and we found that we needed to call
Application.get_env/2
in the application.This PR adds support for loading pool configuration from
Application.get_env/3
when using the module-based pool pattern. Added the:otp_app
option to the__using__
macro, allowing pools to load their configuration from application environment:Configuration can then be set in
runtime.exs
:Useful to configure things from
runtime.ex
without the developers having to come up with that many ways to configure the pools