-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a batch option #150
base: dev
Are you sure you want to change the base?
Added a batch option #150
Conversation
Fixed the target branch, can you resolve the conflicts? |
Hello @lap1nou, Thank you for your PR, this feature is on our roadmap as @ShutdownRepo mentioned but hasn't been completed yet because of its complexity. I will keep your PR on hold for now because there is a lot missing. But, if you have some time to go further i can go into more details. Otherwise i will handle this subject later. |
Hey @Dramelac, @ShutdownRepo, thank you for your answers. If you have other examples of things to change I can try to dig into the subject. Regards. |
To give you more insight, Exegol has been thought for its UX priority, when an important information is missing, an interaction with the user will be requested. I had started a draft of Otherwise here are some cases where a user interaction will be requested:
In each case we have to choose if we want to disable or if we want to take an arbitrary choice. In cases where a CLI option is possible, why not make a critical parameter if its use is justified for example the choice of build profile is mandatory but the change of branch can be ignored if there are no parameters Here are some issues / thoughts I had on the subject, if you want to take the subject and start to do things let me know so I do not launch equivalent work alongside. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this state it's not enough to be merge into the wrapper
Hello,
Description
This PR adds a
-b / --batch
option to answer allConfirm()
call by the default value, this can be useful in case of unattending installation, for example, if Exegol is deployed at scale using Vagrant / SSCM / ...Related issues
N / A
Point of attention
I only tested a classic
exegol install osint -b
, I hope this won't break anything.