updates to make pre mjv changes work with python 3.9 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbeane
approved these changes
Dec 3, 2021
Comment on lines
1
to
+3
| from __future__ import print_function | ||
| from __future__ import absolute_import | ||
| from __future__ import division |
There was a problem hiding this comment.
I'm not sure these from future imports should be kept.
I assume these are here because of concerns about maintaining compatibility with Python2, which I'm not sure is necessary now that Python 2 is no longer supported/updated. Also, this file doesn't appear have any prints, division, or absolute_imports, so I don't think these will make a difference for Python 2 vs Python 3 anyway.
There was a problem hiding this comment.
Yeah, those were all added by the py2 -> py3 tools I used to migrate the code. I can remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep in mind the goal of this PR was to get ImageEchelon working with Python 3 (in this case 3.7, it appears that python 3.9 has breaking changes for the elo package). I wanted something working that would allow me to stand up an instance on a modern vm with new data from the Burgess Lab.