Skip to content

Conversation

@howl19
Copy link

@howl19 howl19 commented Jan 8, 2026

No description provided.

@howl19 howl19 requested a review from TheGiddyLimit as a code owner January 8, 2026 14:24
Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename should likely be Plus Three Press; Elementara.json

@howl19 howl19 changed the title Create plusthreepress; elementara Create plus three press; Elementara.json Jan 11, 2026
Copy link
Author

@howl19 howl19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed file name as requested

@howl19 howl19 requested a review from TheGiddyLimit January 11, 2026 17:14
Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you're missing an "edition" in the "_meta" at the top of the file; other files in the repo have examples

[        JSON] spell/plus three press; elementara.json
[
  {
    "instancePath": "/_meta",
    "schemaPath": "#/required",
    "keyword": "required",
    "params": {
      "missingProperty": "edition"
    },
    "message": "must have required property 'edition'",
    "lineNumberStart": 1,
    "lineNumberEnd": 19
  }
]
Schema test failed (1 failure).

Additionally, the filename should use proper capitalization (i.e. Plus Three Press; Elementara.json)

@howl19 howl19 changed the title Create plus three press; Elementara.json Create Plus Three Press; Elementara.json Jan 18, 2026
Copy link
Author

@howl19 howl19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated title and meta

@TheGiddyLimit
Copy link
Owner

just this left to fix:

image

Additionally, the filename should use proper capitalization (i.e. Plus Three Press; Elementara.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants