Filter imports by list of item#177
Open
darthbeep wants to merge 4 commits into
Open
Conversation
TheGiddyLimit
requested changes
Aug 4, 2023
| }) | ||
|
|
||
| // Filters to match names and sources on the list | ||
| x = importList |
| $btnImport.on("click", () => { | ||
|
|
||
| function filterList () { | ||
| const toSearch = $winText.val().toLowerCase().replaceAll(`"`, "").split("\n"); |
Owner
There was a problem hiding this comment.
$winText.val().toLowerCase().replaceAll(", "").split("\n"); ->
$winText.val().toLowerCase().replaceAll(`"`, "").split("\n").map(it => it.trim()).filter(Boolean);
| $btnImport.on("click", () => { | ||
|
|
||
| function filterList () { | ||
| const toSearch = $winText.val().toLowerCase().replaceAll(`"`, "").split("\n"); |
Owner
There was a problem hiding this comment.
if we have quotes in the input, we should respect them; e.g. "Namedcreature, Bringer of Fun","QWE" should be parsed as name=Namedcreature, Bringer of Fun source=QWE; currently this parses it as name=Namedcreature source=Bringer of Fun?
some generic CSV parsing ought to do the trick; should be simple enough to put in a utility function for it and call it good
| "name": items[0].trim(), | ||
| "source": items.length > 1 ? items[1].trim() : null, | ||
| // Some categories list their source in this format | ||
| "altsource": items.length > 1 ? `src[${items[1].trim()}]`: null, |
Owner
There was a problem hiding this comment.
please make everything uniformly use one style, then remove this workaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to filter what imports are shown by a list of items when importing.