Skip to content

Fix null range in genomic region view #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rehpotsirhc-z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null range in genomic region view #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/pages/GenomicRegionView/RegionViewPlotlyPlot.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const RegionViewPlotlyPlot = React.memo(function RegionViewPlotlyPlot({
exonStructure,
exonStructureTruncated,
}) {
const range = visibleRange || selectedRange;
const range = (visibleRange?.start != null && visibleRange?.end != null) ? visibleRange : selectedRange;
const signalList = Object.entries(signalData).flatMap(
([celltype, signals]) => {
if (
Expand Down
33 changes: 15 additions & 18 deletions frontend/src/pages/GenomicRegionView/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,26 +580,23 @@ function GenomicRegionView() {
return;
}

const init = async () => {
const parsed = parseRegionString(urlRegion);
if (!parsed) return;
const parsed = parseRegionString(urlRegion);
if (!parsed) return;

const {
chromosome: urlChromosome,
start: urlStart,
end: urlEnd,
} = parsed;
const {
chromosome: urlChromosome,
start: urlStart,
end: urlEnd,
} = parsed;

if (
urlChromosome !== selectedChromosome ||
urlStart !== selectedRange?.start ||
urlEnd !== selectedRange?.end
) {
setRegion(urlChromosome, urlStart, urlEnd);
setRegionSearchText(`${urlChromosome}:${urlStart}-${urlEnd}`);
}
};
init();
if (
urlChromosome !== selectedChromosome ||
urlStart !== selectedRange?.start ||
urlEnd !== selectedRange?.end
) {
setRegion(urlChromosome, urlStart, urlEnd);
setRegionSearchText(`${urlChromosome}:${urlStart}-${urlEnd}`);
}
}, [urlRegion]);

// useEffect(() => {
Expand Down