Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset positioned in Builder::clear_insertion_position #561

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Qwox0
Copy link
Contributor

@Qwox0 Qwox0 commented Dec 20, 2024

Description

Resets the positioned field in the Builder::clear_insertion_position method. This fixes the problem described in #560.

Related Issue

Fixes #560.

How This Has Been Tested

$ cargo test -q -F llvm18-0 2>/dev/null

running 3 tests
...
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


running 150 tests
...................................................................i................... 87/150
...............................................................
test result: ok. 149 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.02s


running 344 tests
....................................................................................... 87/344
.............................iiiii..................................................... 174/344
........................................................iiiiiiiiiiii................... 261/344
...................................................................i...............
test result: ok. 326 passed; 0 failed; 18 ignored; 0 measured; 0 filtered out; finished in 3.07s

Checklist

@TheDan64 TheDan64 self-requested a review December 21, 2024 06:00
@TheDan64 TheDan64 merged commit 03c0c6b into TheDan64:master Dec 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder::clear_insertion_position doesn't reset the internal PositionState
2 participants