Significantly faster BIOS exports#15
Open
ScrubN wants to merge 3 commits intoTheCod3rYouTube:mainfrom
Open
Conversation
|
lgtm |
|
great changes mate, there can always be a better wheel ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although still not optimal, this drops BIOS export times from almost a minute to less than a second.
File.WriteAllBytesoverwrites the file if it exists, only the final write is needed.PatternAtto use spans instead of LINQ, which removes 2 heap allocations per comparison (fromSkipandTake) and uses a SIMD vectorized comparison function instead of the while-loop based sequence compare from LINQ.