Fix #9 (.BIN instead of .bin extension)#12
Open
stevebroskey wants to merge 2 commits intoTheCod3rYouTube:mainfrom
Open
Fix #9 (.BIN instead of .bin extension)#12stevebroskey wants to merge 2 commits intoTheCod3rYouTube:mainfrom
stevebroskey wants to merge 2 commits intoTheCod3rYouTube:mainfrom
Conversation
Fixes TheCod3rYouTube#9 (TheCod3rYouTube#9) Better fix would involve doing something case-insensitive. I'm no C# dev, but consider combining https://stackoverflow.com/a/55480402 with https://stackoverflow.com/a/69284465.
|
This wouldn't fix the issue. Paths on Windows are case-insensitive, and the message box isn't coming from the |
|
To fix that, change this line. PS5NorModifier/PS5 NOR Modifier/Form1.cs Line 374 in 3064e07 to if(!fileDialogBox.SafeFileName.ToLower().EndsWith(".bin")) |
|
Even better, use string comparisons: - if(!fileDialogBox.SafeFileName.EndsWith(".bin"))
+ if(!fileDialogBox.SafeFileName.EndsWith(".bin", StringComparison.OrdinalIgnoreCase)) |
Fix better: TheCod3rYouTube#12 (comment)
sugoidogo
pushed a commit
to sugoidogo/PS5NorModifier
that referenced
this pull request
May 10, 2025
Fix better: TheCod3rYouTube#12 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Better fix would involve doing something case-insensitive. I'm no C# dev, but consider combining https://stackoverflow.com/a/55480402 with https://stackoverflow.com/a/69284465.
Thanks to Louis Rossmann for bringing attention to this worthwhile project: https://www.youtube.com/watch?v=fEMR6zKP9l8