Skip to content

Commit

Permalink
Homebrew shouldn't install themes
Browse files Browse the repository at this point in the history
  • Loading branch information
isaacroldan committed Apr 16, 2024
1 parent 8f3354b commit 87e62e7
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 16 deletions.
5 changes: 2 additions & 3 deletions bin/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,10 @@ function getTemplateVersion(version) {
}

async function getHomebrewVariables(cliVersion) {
const [[cliTarball, cliSha], [themeTarball, themeSha]] = await Promise.all([
const [[cliTarball, cliSha]] = await Promise.all([
getTarballAndShaForPackage('@shopify/cli', cliVersion),
getTarballAndShaForPackage('@shopify/theme', cliVersion),
])
return {cliTarball, cliSha, themeTarball, themeSha}
return {cliTarball, cliSha}
}

async function getTarballAndShaForPackage(pkg, cliVersion) {
Expand Down
9 changes: 0 additions & 9 deletions packaging/3/src/shopify-cli.rb.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ class ShopifyCli{% if formulaVersion %}{% if formulaVersion == '3' %}AT3{% else
depends_on "ruby"
depends_on "git"

resource "cli-theme-commands" do
url "{{ themeTarball}}"
sha256 "{{ themeSha }}"
end

livecheck do
url :stable
end
Expand Down Expand Up @@ -52,9 +47,5 @@ class ShopifyCli{% if formulaVersion %}{% if formulaVersion == '3' %}AT3{% else
FileUtils.chmod("+x", executable_path)

bin.install_symlink executable_path

resource("cli-theme-commands").stage {
system "npm", "install", *Language::Node.std_npm_install_args(libexec)
}
end
end
2 changes: 0 additions & 2 deletions packaging/3/src/[email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@
formulaVersion: '3',
cliTarball: cliTarball,
cliSha: cliSha,
themeTarball: themeTarball,
themeSha: themeSha
%}
2 changes: 0 additions & 2 deletions packaging/nightly/src/shopify-cli-nightly.rb.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@
formulaVersion: 'nightly',
cliTarball: cliTarball,
cliSha: cliSha,
themeTarball: themeTarball,
themeSha: themeSha
%}

0 comments on commit 87e62e7

Please sign in to comment.