Skip to content

MAM-3841-integrate-react-native#384

Draft
bnolens wants to merge 19 commits into
mainfrom
MAM-3841-integrate-react-native
Draft

MAM-3841-integrate-react-native#384
bnolens wants to merge 19 commits into
mainfrom
MAM-3841-integrate-react-native

Conversation

@bnolens
Copy link
Copy Markdown
Member

@bnolens bnolens commented Feb 2, 2024

  • Integrated React Native
  • Added a simple composer UI using RN + native components
  • Updated README

MAM-3841 : Integrate React-Native

@bnolens bnolens requested a review from rileyhCode February 2, 2024 16:41
Comment thread README.md Outdated
- Node.js 20.10.+
- Xcode 13+
- Swift 5+
- Yarn 1.22+
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a callout that this isn't the latest version?
(maybe point people here? not sure https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable)

Copy link
Copy Markdown
Member Author

@bnolens bnolens Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to run an older version. Good catch! I updated it to the latest version.

Comment thread README.md Outdated
1. Copy the `sample.env` to `.env`
1. Run `bundle install` to get the needed gems
1. From the root of the application still run `bin/arkana` This will generated
1. Run `yarn` to install dependencies
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What directory should the user be in?

Comment thread README.md
1. From the root of the application still run `bin/arkana` This will generated
1. Run `yarn` to install dependencies
1. From the [ios](./ios) directory run `bundle install` to get the needed gems
1. From the [ios](./ios) directory run `bin/arkana` This will generated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I had to move the .arkana.yml into the ios directory.

Comment thread ios/.xcode.env.local Outdated
@@ -0,0 +1,2 @@
export NODE_BINARY=/opt/homebrew/bin/node
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mine was in a different location. Maybe this should be which node or…?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be ignored by git and generated when running ... pod install

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it from git. So next time you run USE_FRAMEWORKS=static RCT_NEW_ARCH_ENABLED=1 arch -x86_64 bundle exec pod install the file should be generated locally

Copy link
Copy Markdown
Contributor

@rileyhCode rileyhCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some thoughts.

@bnolens bnolens requested a review from rileyhCode February 5, 2024 10:00
Copy link
Copy Markdown

@jtomchak jtomchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Comment thread .yarnrc.yml Outdated
@@ -0,0 +1,3 @@
nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.1.0.cjs
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creates errors on fresh installs, remove yarnPath:

Now that Corepack is shipped with both Node 18 and 20 we no longer need to rely on yarnPath, and as a result we updated our installation guide to reflect that. The yarn init -2 and yarn set version commands have been updated to favor updating the packageManager field when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants