Add check in Extrude(), replace replace codecvt_utf8_utf16 #1282
Conversation
…the outer loop of the shape is not closed
- enable polylines as mesh for IFCGRID, IFCGRIDAXIS - add bounds checks in TriangulateRevolution
make scaling by _geometryLoader.GetLinearScalingFactor() optional in GetFlatMesh. Alternative would be: make IfcGeometryProcessor::AddComposedMeshToFlatMesh public
|
Thanks for this! The following IFC files in the tests output has changed. Can you check the changes are positive i.e. have improved the rendering and then you need to re run npm run update-regression to update the result cahce tests/ifcfiles/public/AC20-FZK-Haus.ifc- FAIL |
…TESIANPOINT as geometric item IFCFACESURFACE, IFCEDGE and IFCCARTESIANPOINT are derived from IfcRepresentationItem, so they could appear as geometric item In IfcGeometryLoader::GetColor: add check for curveColour because it is optional
|
During testing the files in tests/ifcfiles/public/ a few issues came up which are addressed in this pr: #1300 |
|
Hi,
When I load these models even with the unchanged code, there are many such messages. Maybe the outer bound error could be classified as warning? Since these are quite common. |
|
So yes getting that is normal - so as long as the models look visually OK - then it is fine |
|
I am not sure if it is possible to visually check the models converted by the test workflow. |
|
OK fab - that's what I meant. Can you run npm run regression-update and then push those changes. Or give me access to update the PR and I can do it. Does #1300 need to merged first - or at the same time? Because that still has errors |
|
I did run "npm run regression-update", then pushed the changes (results.json), but it still looks the same. #1300 can be merged at the same time |
In Extrude(): check if first point is equal to last point, otherwise the outer loop of the shape is not closed
In string_parsing.cpp, replace codecvt_utf8_utf16 which is deprecated in C++17