Closed
Conversation
Co-authored-by: vitopigno <103512727+VitusVeit@users.noreply.github.com>
…station#972) Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: Tay <td12233a@gmail.com>
<!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> ## About the PR <!-- What did you change? --> ## Why / Balance <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. --> ## Technical details <!-- Summary of code changes for easier review. --> ## Media <!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. --> ## Requirements <!-- Confirm the following by placing an X in the brackets [X]: --> - [ ] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [ ] I have added media to this PR or it does not require an ingame showcase. <!-- You should understand that not following the above may get your PR closed at maintainer’s discretion --> ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Changelog** <!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay. Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up. Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog. --> <!-- 🆑 - add: Added fun! - remove: Removed fun! - tweak: Changed fun! - fix: Fixed fun! -->
* feat: node scanner now auto-updates artifact details if in range * refactor: minor cleanup * refactor: optimization for update and query of range checking * refactor: fix xml-doc --------- Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
* fixing spessman getting teleported inside artifact * refactor: move XAEPortal comp to server * refactor: replace Spawn and coord logic with with TrySpawnNextTo --------- Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
…station#986) Co-authored-by: Kittygyat <202250949+Kittygyat@users.noreply.github.com>
Co-authored-by: Tay <td12233a@gmail.com>
Minor fix
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
… Wizden (funky-station#1190) Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: Southbridge <7013162+southbridge-fur@users.noreply.github.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: Crude Oil <124208219+CroilBird@users.noreply.github.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: V <97265903+formlessnameless@users.noreply.github.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: AsnDen <75905158+AsnDen@users.noreply.github.com> Co-authored-by: funkystationbot <funky@funkystation.org>
…s, and Rat Kings from Wizden (funky-station#1161) Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: YoungThug <ramialanbagy@gmail.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: funkystationbot <funky@funkystation.org>
…zden (funky-station#1177) Co-authored-by: hoshizora <willhornbeck12@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
…ation#1155) Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: EmoGarbage404 <retron404@gmail.com> Co-authored-by: Unkn0wn_Gh0st <shadowstalkermll@gmail.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: Tay <td12233a@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: Orsoniks <orsoniksstuff@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
…ion#1148) Co-authored-by: Matthew Herber <32679887+happyrobot33@users.noreply.github.com> Co-authored-by: imatsoup <93290208+imatsoup@users.noreply.github.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org> Co-authored-by: Tay <td12233a@gmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: funkystationbot <funky@funkystation.org>
…ion#1200) Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: ScarKy0 <scarky0@onet.eu> Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com> Co-authored-by: Velken <8467292+Velken@users.noreply.github.com> Co-authored-by: 8tv <eightev@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
…ation#1209) Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: kallalilies <kallikinlaw@gmail.com> Co-authored-by: funkystationbot <funky@funkystation.org>
Co-authored-by: funkystationbot <funky@funkystation.org> Co-authored-by: Tay <td12233a@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Gives the Golden toolbox located inside the station the same statline as the suspicious toolbox,
(8x4 inventory, 20 blunt damage on hit)
With it also being given autoswing,
(its not very relavent given its slow attack rate but it is funny)
And is now clasified as command contraband.
Why / Balance
I would not be supprised if a lot of people who saw the golden toolbox for the first time assumed it was something special only to be dissapointed its just a retexrued regular toolbox
Alongside the vault itself not really having anything special inside of it other than the nuke, witch is not even relevant in a majority of rounds
Wich it now being classified as command contraband it properly signals that this is a notable item, but its techinaly not specific to any member of command and its entirirely up to them how much will they care about it, some will want to be protective of it, others wont care, and some might just hand it over to a tider they deem worthy enough.
Now with the stat changes it becomes a properly special item that is worth paying attention to.
[This is a old joke PR i made awhile back that i never bothered to fix because i also wanted it to be a thief objective, but now that they are freeform i decided to resubmit this]
Technical details
just a very simple .yml change
Media
Requirements
Changelog
🆑 ThatOneMoon
-->