Skip to content

Fix richhandler ignores time zone fromat specifier #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmmarAbdelhalem wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Fix richhandler ignores time zone fromat specifier #3898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c444dc
Fix naive datetime in RichHandler (refs #3877)
AmmarAbdelhalem Nov 29, 2025
fe88964
add fix desc to CHANGELOG.md file and add my name to CONTRIBUTORS.md …
AmmarAbdelhalem Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed extraction of recursive exceptions https://github.com/Textualize/rich/pull/3772
- Fixed padding applied to Syntax https://github.com/Textualize/rich/pull/3782
- Fixed `Panel` title missing the panel background style https://github.com/Textualize/rich/issues/3569
- Fixed RichHandler log time rendering by converting naive datetimes to timezone-aware to ensure correct display https://github.com/Textualize/rich/issues/3877

### Added

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,4 @@ The following people have contributed to the development of Rich:
- [Jonathan Helmus](https://github.com/jjhelmus)
- [Brandon Capener](https://github.com/bcapener)
- [Alex Zheng](https://github.com/alexzheng111)
- [Ammar Abdelhalem](https://github.com/ammarabdelhalem)
2 changes: 1 addition & 1 deletion rich/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def render(
path = Path(record.pathname).name
level = self.get_level_text(record)
time_format = None if self.formatter is None else self.formatter.datefmt
log_time = datetime.fromtimestamp(record.created)
log_time = datetime.fromtimestamp(record.created).astimezone()

log_renderable = self._log_render(
self.console,
Expand Down