Refactor/relacement names #516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All platforms currently use __PART_FAMILY_NAME__ to point at an explicit device name. Update this platform to match. Signed-off-by: Randolph Sapp <[email protected]>
Replace all instances of __PART_FAMILY_DEVICE_NAMES__ with __PART_FAMILY_NAME__ since the two are equivalent. Signed-off-by: Randolph Sapp <[email protected]>
Remove the __PART_FAMILY_DEVICE_NAMES__ replacement definition since it is no longer used. Signed-off-by: Randolph Sapp <[email protected]>
github-actions
bot
assigned
3V3RYONE,
aniket-l,
bryanbrattlof,
devarsht,
DhruvaG2000,
glaroque,
jmenti,
makohoek,
praneethbajjuri and
r-vignesh
StaticRocket
requested review from
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(names): remove PART_FAMILY_DEVICE_NAMES
Remove the PART_FAMILY_DEVICE_NAMES replacement definition since it is no
longer used.
Signed-off-by: Randolph Sapp [email protected]
refactor(names): use shorter replacement name
Replace all instances of PART_FAMILY_DEVICE_NAMES with
PART_FAMILY_NAME since the two are equivalent.
Signed-off-by: Randolph Sapp [email protected]
fix(TDA4VM): set PART_FAMILY_NAME to device
All platforms currently use PART_FAMILY_NAME to point at an explicit
device name. Update this platform to match.
Signed-off-by: Randolph Sapp [email protected]
Opening as a draft for now as there are other cleanup efforts I assume will clash with this currently.