Fix focus trap: focus textarea on open and restore focus on close - #486
Open
onyekachi66 wants to merge 1 commit into
Open
Fix focus trap: focus textarea on open and restore focus on close#486onyekachi66 wants to merge 1 commit into
onyekachi66 wants to merge 1 commit into
Conversation
|
@onyekachi66 is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427
TL;DR
When the mobile chat sidebar (implemented as a bottom‑sheet) opens, the input textarea should receive focus automatically. When the sheet is closed (via Escape or overlay click) focus must be restored to the button that opened the sheet. This PR adds the missing
initialFocusRefto the existinguseFocusTraphook usage, preserving the existing tab‑cycling behavior and ensuring a smooth keyboard‑only experience.Background
The mobile chat UI is displayed as a bottom‑sheet (
<aside>).Current behavior:
restoreFocusRef).Issue: The spec requires that focus immediately lands on the textarea when the sheet opens, and that focus is restored correctly on close. The
useFocusTraphook already supports aninitialFocusRefprop, but it was never supplied.Changes Made
src/components/ChatSidebar.tsxuseFocusTrapcall to include:tsx\nuseFocusTrap(sidebarRef, {\n active: isMobileOpen,\n onEscape: () => setIsMobileOpen(false),\n initialFocusRef: textareaRef, // 👈 new\n restoreFocusRef: mobileToggleRef,\n});\nAll other logic remains unchanged.
No other files were touched.
The only functional addition is passing
textareaRef(the ref for the<textarea>input) asinitialFocusRef.Implementation Details
useFocusTrapHook (src/hooks/useFocusTrap.ts):initialFocusRef?: RefObject<HTMLElement>and focuses that element when the trap becomes active.restoreFocusRefon cleanup.Component Integration (
ChatSidebar):textareaRefis already defined (useRef<HTMLTextAreaElement>(null)).window.setTimeout(..., 0)) as soon as the sheet is rendered andisMobileOpenbecomes true.restoreFocusRef: mobileToggleRefcontinues to return focus to the toggle button when the sheet is closed.No New Dependencies – The hook and refs were already present; we only wired them together.
Verification / Testing Plan
Automated (manual verification)
Impact Assessment
focus()call on mount.focus()on textarea elements; uses the existinguseFocusTrapimplementation that already handles key events.Related Issues / Tickets
Checklist
npm run lint && npm run build– passes).