Consolidate ComingSoon templates into ComingSoonPage - #482
Merged
josephchimebuka merged 1 commit intoAug 26, 2026
Merged
Conversation
Remove the orphaned ComingSoon template introduced in TevaLabs#215. ComingSoonPage is the single shared component with icon/title/description/CTA slots and is already used by the /tournament route, so no route migration is needed. Closes TevaLabs#401 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@brodapeethar is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #401
There were two coming-soon page templates (
ComingSoonandComingSoonPage) rendering the placeholder surfaces inconsistently. This PR consolidates them into a single shared component.Changes
src/pages/ComingSoonPage.tsxas the single template — it exposesicon/title/descriptionslots plus a CTA (back navigation), which matches the design used by placeholder routes./tournamentroute — it already consumedComingSoonPage, so no route change was required. No other routes referenced the old template.src/pages/ComingSoon.tsx— it was orphaned (last wired up in Wire ModeCards CTA links to real routes and coming-soon states #215) and had drifted from the current design language (custom SVG fallback icon, launch-timeline box,Notify Melink).Acceptance criteria
ComingSoonPageonly)/tournamentrendersComingSoonPagewith theTrophyicon)Testing
pnpm build— passes (TypeScript + Vite production build)pnpm test:unit— 780 tests passing (62 files)pnpm lint— only pre-existingreact-hooks/set-state-in-effecterrors in unrelated files (PredictionHistory.tsx,PriceChart.tsx,Dashboard.tsx,Learn.tsx); no new issues introducedNo env vars, migrations, or manual QA steps required.