Skip to content

feat(ui): add shared Spinner primitive and replace one-off loading spinners - #481

Merged
josephchimebuka merged 1 commit into
TevaLabs:mainfrom
zainabwahab-eth:feat/403-shared-spinner-primitive
Aug 26, 2026
Merged

feat(ui): add shared Spinner primitive and replace one-off loading spinners#481
josephchimebuka merged 1 commit into
TevaLabs:mainfrom
zainabwahab-eth:feat/403-shared-spinner-primitive

Conversation

@zainabwahab-eth

Copy link
Copy Markdown
Contributor

Closes #403

Changes

  • New component: src/components/ui/Spinner.tsx - A shared, accessible Spinner primitive with size variants (sm/md/lg) and label prop for screen reader announcements
  • Pools (src/pages/Pools.tsx): Replaced one-off inline SVG spinner with shared Spinner (size="lg", label="Loading pools")
  • Profile (src/pages/Profile.tsx): Replaced one-off Loader2 spinner with shared Spinner (size="lg", label="Loading profile")
  • Connect (src/pages/Connect.tsx): Replaced two one-off Loader2 spinners with shared Spinner (size="sm", labels "Validating address" and default)

Accessibility

All three call sites now use the shared Spinner which includes:

  • role="status" ARIA attribute
  • aria-label prop passed through from each call site so screen readers announce the loading state
  • motion-safe:animate-spin for reduced motion preference

Validation

  • Type-check: passed
  • Lint: 6 pre-existing errors (unrelated to this change)
  • Tests: 780/780 passed
  • Build: passed
  • Accessibility smoke test: 4/4 passed

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@zainabwahab-eth is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel.

A member of the Team first needs to authorize it.

@josephchimebuka
josephchimebuka merged commit 3fa93f7 into TevaLabs:main Aug 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Normalize loading UI to a shared Spinner / skeleton primitive

2 participants