Rebuild: allowlist/denylist access-control gate on mutators - #461
Open
Olamidepy wants to merge 1 commit into
Open
Rebuild: allowlist/denylist access-control gate on mutators#461Olamidepy wants to merge 1 commit into
Olamidepy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issues
Docs reference
PROTOCOL_SPEC.md— invariants (I1–I13) updated if affecteddocs/EVENT_SCHEMA.md— event schema updated if new/changed eventsMIGRATION.md— breaking changes documented with migration pathCOMPATIBILITY_POLICY.md— MAJOR/MINOR/PATCH classification notedSECURITY_REVIEW.md— open findings referenced if affectedcontracts/BENCHMARKS.md— benchmark evidence included if hot paths changedValidation
cargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkcd bindings && npm ci && npm run buildGovernance checklist
CONTRIBUTING.mdfor workflow expectationsCODEOWNERSimpact for touched pathsSUPPORT.mddisclosure guidance for any security-sensitive changeLabels
protocol,security,bug,enhancement,testing,blockchain,contract,Rust,priority: high/medium/low) as described inCONTRIBUTING.mdSmart-Contract Security Checklist
1. Authentication & Access Control
require_auth()or appropriate admin/oracle checks.2. Safe Arithmetic & Overflow Protection
checked_add,checked_sub,checked_mul, etc.) are used for all state changes.payout_add/payout_mul) where applicable.3. Lifecycle & State Transitions
4. Event Emission & Observability
5. Tests & Verification
Critical Path Changes
Does this PR modify contract payout, resolution, or claim paths?
If yes, note details:
Are there any new failure modes introduced by these changes?
If yes, note details:
Snapshot policy
contracts/test_snapshots/changed, I reviewed the diff and confirmed every change is intentionalcloses #392