Skip to content

Gives access to version information for each installed selector engine #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krukow wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gives access to version information for each installed selector engine #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3ff9c
added engines to version command
krukow Jul 20, 2013
a94da20
fix accidental leak
krukow Jul 20, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Shelley
Open in desktop
Submodule Shelley updated 25 files
+19 −0 Shelley.podspec
+177 −152 Shelley.xcodeproj/project.pbxproj
+0 −0 Source/Frank/SYFrankSelectorEngine.h
+4 −0 Source/Frank/SYFrankSelectorEngine.m
+0 −0 Source/Frank/SelectorEngineRegistry.h
+0 −0 Source/Mac/NSObject+ShelleyExtensions.m
+0 −0 Source/Shared/Filters/SYArrayFilterTemplate.h
+0 −0 Source/Shared/Filters/SYArrayFilterTemplate.m
+0 −0 Source/Shared/Filters/SYClassFilter.h
+12 −0 Source/Shared/Filters/SYClassFilter.m
+0 −0 Source/Shared/Filters/SYFilter.h
+0 −0 Source/Shared/Filters/SYNthElementFilter.h
+0 −0 Source/Shared/Filters/SYNthElementFilter.m
+0 −0 Source/Shared/Filters/SYParents.h
+0 −0 Source/Shared/Filters/SYParents.m
+0 −0 Source/Shared/Filters/SYPredicateFilter.h
+0 −0 Source/Shared/Filters/SYPredicateFilter.m
+0 −0 Source/Shared/LoadableCategory.h
+0 −0 Source/Shared/SYParser.h
+0 −0 Source/Shared/SYParser.m
+0 −0 Source/Shared/Shelley.h
+0 −0 Source/Shared/Shelley.m
+0 −0 Source/Shelley-Prefix.pch
+0 −0 Source/ShelleyMac-Prefix.pch
+0 −0 Source/iOS/UIView+ShelleyExtensions.m
1 change: 1 addition & 0 deletions src/SelectorEngineRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@
+ (NSArray *) selectViewsWithEngineNamed:(NSString *)engineName usingSelector:(NSString *)selector;

+ (NSArray *)getEngineNames;
+ (id<SelectorEngine>)engineForName:(NSString *)engineName;
@end
4 changes: 4 additions & 0 deletions src/SelectorEngineRegistry.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,8 @@ + (NSArray *) selectViewsWithEngineNamed:(NSString *)engineName usingSelector:(N
+ (NSArray *)getEngineNames {
return [s_engines allKeys];
}

+ (id<SelectorEngine>)engineForName:(NSString *)engineName {
return [s_engines objectForKey:engineName];
}
@end
20 changes: 19 additions & 1 deletion src/VersionCommand.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
//

#import "VersionCommand.h"
#import "SelectorEngineRegistry.h"
#import "JSON.h"

@implementation VersionCommand {
NSString *_version;
Expand All @@ -28,7 +30,23 @@ - (void)dealloc
}

- (NSString *)handleCommandWithRequestBody:(NSString *)requestBody {
return [NSString stringWithFormat:@"{\"version\":\"%@\"}",_version];
NSMutableDictionary *engineVersions = [NSMutableDictionary dictionary];
for (NSString *engineName in [SelectorEngineRegistry getEngineNames]) {
id<SelectorEngine> engine = [SelectorEngineRegistry engineForName:engineName];
SEL versionSel = @selector(version);
if ([engine respondsToSelector:versionSel]) {
NSDictionary *engineVersionData = [engine performSelector:versionSel];
[engineVersions setObject:engineVersionData forKey:engineName];
}
else {
[engineVersions setObject:[NSNull null] forKey:engineName];
}
}
NSDictionary *versionResult = [NSDictionary dictionaryWithObjectsAndKeys:
_version, @"version",
engineVersions, @"engines",
nil];
return TO_JSON(versionResult);
}

@end