Skip to content

fix: use dotnet nuget to push packages#80

Merged
vbreuss merged 1 commit into
mainfrom
topic/use-dotnet-nuget
Aug 13, 2025
Merged

fix: use dotnet nuget to push packages#80
vbreuss merged 1 commit into
mainfrom
topic/use-dotnet-nuget

Conversation

@vbreuss

@vbreuss vbreuss commented Aug 13, 2025

Copy link
Copy Markdown
Member

This PR modernizes the NuGet package publishing process by replacing the legacy nuget.exe tool with the built-in dotnet nuget command. This change follows best practices recommended in Meziantou's blog for more reliable and streamlined package publishing.

Key changes:

  • Replaces nuget push with dotnet nuget push command using updated parameter syntax
  • Adds .NET SDK setup to ensure dotnet command availability
  • Updates dotnet-stryker tool version to 4.7.0

This PR modernizes the NuGet package publishing process by replacing the legacy `nuget.exe` tool with the built-in `dotnet nuget` command. This change follows best practices recommended in [Meziantou's blog]((https://www.meziantou.net/publishing-a-nuget-package-following-best-practices-using-github.htm)) for more reliable and streamlined package publishing.

**Key changes:**
- Replaces `nuget push` with `dotnet nuget push` command using updated parameter syntax
- Adds .NET SDK setup to ensure `dotnet` command availability
- Updates dotnet-stryker tool version to 4.7.0
@vbreuss vbreuss self-assigned this Aug 13, 2025
Copilot AI review requested due to automatic review settings August 13, 2025 16:58
@vbreuss vbreuss added the bug Something isn't working label Aug 13, 2025
@vbreuss vbreuss enabled auto-merge (squash) August 13, 2025 16:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the NuGet package publishing process by replacing the legacy nuget.exe tool with the built-in dotnet nuget command for more reliable package publishing.

  • Updates package publishing command from nuget push to dotnet nuget push with modernized parameter syntax
  • Adds .NET SDK setup step to ensure dotnet command availability in the workflow
  • Updates dotnet-stryker tool to version 4.7.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Pipeline/Build.MutationTests.cs Updates dotnet-stryker tool version to 4.7.0
.github/workflows/build.yml Modernizes NuGet publishing by adding .NET SDK setup and replacing nuget.exe with dotnet nuget command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/build.yml
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

   10 files  ±0     10 suites  ±0   5s ⏱️ -1s
  484 tests ±0    483 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 440 runs  ±0  1 439 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 37d4b99. ± Comparison against base commit 543ff9e.

@github-actions

Copy link
Copy Markdown

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.2 LTS (Noble Numbat)
AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores
.NET SDK 9.0.304
[Host] : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2
DefaultJob : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2

Method Mean Error StdDev Gen0 Allocated
Content_aweXpect 539.4 ns 5.86 ns 5.48 ns 0.0629 1064 B
SuccessStatusCode_aweXpect 295.3 ns 5.72 ns 5.62 ns 0.0496 832 B

@github-actions

Copy link
Copy Markdown

👽 Mutation Results

Mutation testing badge

aweXpect.Web

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

@vbreuss vbreuss merged commit de8f2a6 into main Aug 13, 2025
12 checks passed
@vbreuss vbreuss deleted the topic/use-dotnet-nuget branch August 13, 2025 17:03
@github-actions

Copy link
Copy Markdown

This is addressed in release v1.4.0.

@github-actions github-actions Bot added the state: released The issue is released label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants