Skip to content

fix: prefer AsSpan over Substring where span overloads are available #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 1 commit into from
May 10, 2026
Merged

fix: prefer AsSpan over Substring where span overloads are available #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Source/aweXpect.Json/Helpers/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ public static string TrimCommonWhiteSpace(this string value)
sb.Append(lines[0]);
foreach (string? line in lines.Skip(1))
{
#if NET8_0_OR_GREATER
sb.Append('\n').Append(line.AsSpan(commonWhiteSpace.Length));
#else
sb.Append('\n').Append(line.Substring(commonWhiteSpace.Length));
#endif
Comment on lines +53 to +57
}

return sb.ToString();
Expand Down
4 changes: 4 additions & 0 deletions Source/aweXpect.Json/Json/ExpectationJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ public bool TryGetExpectation(JsonElement element,
{
string? value = element.GetString();
if (value?.StartsWith(Prefix) == true &&
#if NET8_0_OR_GREATER
Guid.TryParse(value.AsSpan(Prefix.Length), out Guid guid) &&
#else
Guid.TryParse(value.Substring(Prefix.Length), out Guid guid) &&
#endif
_expectations.TryGetValue(guid, out Expectation? expectation) &&
expectation is IOptionsProvider<ExpectationBuilder>
{
Expand Down
Loading