Skip to content

refactor: simplify InvokeGetter in PropertySetup #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 1 commit into from
Jan 25, 2026
+0 −17
Merged

refactor: simplify InvokeGetter in PropertySetup #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Source/Mockolate/Setup/PropertySetup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,6 @@ protected override TResult InvokeGetter<TResult>(MockBehavior behavior, Func<TRe
}
}

if (!_isInitialized)
{
_value = defaultValueGenerator() is T value ? value : default!;
_isInitialized = true;
}

if (!TryCast(_value, out TResult result))
{
throw new MockException(
Expand Down
11 changes: 0 additions & 11 deletions Tests/Mockolate.Tests/MockProperties/SetupPropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,6 @@ namespace Mockolate.Tests.MockProperties;

public sealed partial class SetupPropertyTests
{
[Fact]
public async Task InitializeValue_NotMatchingTypes_ShouldUseDefault()
{
MyPropertySetup<int> setup = new();

setup.MyInitializeValue("f");

int result = setup.InvokeGetter<int>();
await That(result).IsEqualTo(0);
}

[Fact]
public async Task InvokeGetter_InvalidType_ShouldThrowMockException()
{
Expand Down
Loading