refactor: remove redundant check in ReturnMethodSetup

[vbreuss]

This PR removes redundant null checks in the ReturnMethodSetup class that were checking if _returnCallbacks.Count == 0 before processing method invocations. These checks are unnecessary because the base class implementation already handles this scenario appropriately.

Key Changes:

• Removed redundant early-return checks for empty _returnCallbacks from four overloaded GetReturnValue methods
• Added comprehensive test coverage to verify that the setup behavior works correctly both with and without explicit return values

[Copilot]

Pull request overview

This PR removes redundant null checks in the ReturnMethodSetup class that were checking if _returnCallbacks.Count == 0 before processing method invocations. These checks are unnecessary because the base class implementation already handles this scenario appropriately.

Changes:

• Removed redundant early-return checks for empty _returnCallbacks from four overloaded GetReturnValue methods
• Added comprehensive test coverage to verify that the setup behavior works correctly both with and without explicit return values

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
Source/Mockolate/Setup/ReturnMethodSetup.cs	Removed redundant _returnCallbacks.Count == 0 checks from four GetReturnValue method overloads
Tests/Mockolate.Tests/MockMethods/SetupMethodTests.ReturnsThrowsTests.cs	Added test cases SetupWithReturn_ShouldUseBaseValue and SetupWithReturn_ShouldIgnoreBaseValue for methods with 0-5 parameters to ensure proper behavior after removing the checks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)

AMD EPYC 7763 2.61GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.102

[Host] : .NET 10.0.2 (10.0.2, 10.0.225.61305), X64 RyuJIT x86-64-v3
Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
Simple_Mockolate	1.579 μs	0.0153 μs	0.0128 μs	0.2270	-	3.73 KB
Simple_Moq	178.966 μs	0.8526 μs	0.7558 μs	0.4883	-	14.71 KB
Simple_NSubstitute	5.784 μs	0.0159 μs	0.0141 μs	0.5569	0.0076	9.14 KB
Simple_FakeItEasy	6.842 μs	0.0295 μs	0.0276 μs	0.4959	-	8.11 KB

[github-actions]

Test Results

    21 files  ± 0      21 suites  ±0   5m 35s ⏱️ -17s
 2 374 tests + 6   2 373 ✅ + 6  1 💤 ±0  0 ❌ ±0 
15 923 runs  +42  15 922 ✅ +42  1 💤 ±0  0 ❌ ±0 

Results for commit 7b40c13. ± Comparison against base commit 5dab55b.

[github-actions]

This is addressed in release v1.0.3.