Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added the exception check in original code #1256

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oni-shiro
Copy link

Due to missing resx files, can not create the localised string as of now.

Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we would need this, as this method should only be a wrapper around the native Directory.Move. The idea of this library is to not change the behaviour of the underlying file system!

@oni-shiro
Copy link
Author

oni-shiro commented Mar 31, 2025

I added this check to handle this issue As it states, the wrapper class and the mock class differ in behaviour.
Another fix would be removing this checks from mock class instead of adding them in wrapper class. Let me know your thoughts.

@vbreuss
Copy link
Member

vbreuss commented Mar 31, 2025

@oni-shiro:
The goal of this library is to provide a wrapper and testing helper that behaves exactly the same as the native file system. The wrapper class should only wrap the native calls so that they can be tested.
When an issue describes a different behaviour between the native file system and the testing helpers, it is always the testing helpers that should be adapted.

I assigned #1138 to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants