Improve update check #972
Open
Improve update check #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the version resolution is not critical it's likely better to have it here. The previously used `backgroundExecutor` is used for internal resource reloading during game initialization which can cause it to get stuck when the download hangs (e.g. when using 3rd party mods that modify resource reloading like Continuity)
litetex
force-pushed
the
improve-update-check
branch
from
3567809 to
7d8cb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address 2 problems from #953 (comment)
checkForUpdates0)checkForUpdates0to finish - This is not needed and just blocks the underlying threadIt might also be helpful to backport these changes