Skip to content

Add timeouts for HTTP requests #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gniftygnome merged 1 commit into from
Jan 21, 2026
Merged

Add timeouts for HTTP requests #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/terraformersmc/modmenu/util/HttpUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
import java.net.http.HttpClient;
import java.net.http.HttpRequest;
import java.net.http.HttpResponse;
import java.time.Duration;

public class HttpUtil {
private static final Duration TIMEOUT = Duration.ofSeconds(30);
private static final String USER_AGENT = buildUserAgent();
private static final HttpClient HTTP_CLIENT = HttpClient.newBuilder()
.executor(Util.nonCriticalIoPool())
.connectTimeout(TIMEOUT)
.build();

private HttpUtil() {
Expand All @@ -24,6 +27,7 @@ public static <T> HttpResponse<T> request(
HttpResponse.BodyHandler<T> handler
) throws IOException, InterruptedException {
builder.setHeader("User-Agent", USER_AGENT);
builder.timeout(TIMEOUT);
return HTTP_CLIENT.send(builder.build(), handler);
}

Expand Down