Conversation
Contributor
|
This is updating the button text in the config screen, correct? An obvious issue with this change is it will make both of those buttons' text too long to fit in the button (in English). |
Contributor
Author
|
That is true, it would overflow and scroll. An alternative could be to have sections where certain buttons are under (e.g. "Button", "Menu", ...) like the 1.21.11 video settings, though I am unsure how to do that right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't remember how it was before but currently it doesn't seem entirely obvious what options "Title Screen" and "Game Menu" are, hence I suggest adding a word "button" to them, to indicate that they refer to the Mods button.