You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#604 by allowing the user to choose between receiving all updates, betas and releases, or only releases (default).
This branch is based on the work from #679 and I will keep this as a draft until Max's work is merged into the upstream repo.
It'd however be awesome if these two PRs could land in the same release of ModMenu so I do not have to mark the new method in the UpdateInfo interface as being optional (and prob end up not being used a lot).
I just realized earlier that the update checking logic could be a bit smarter if the user can choose a channel, so this has been adjusted.
By making the user's preference for an update channel available to the update checker we can now handle a situation in which the user is on version 1.0.0 for a mod, and both version 1.0.1 and 1.1.0-beta.1 are available. If the preference is to only receive release versions the update checker can return version 1.0.1, otherwise it can return version 1.1.0-beta.1.
I don't think the Modrinth API supports selecting which version types one is looking for in the get latest versions from hashes route, so this can sadly not improve the update checking experience for mods not using a custom update checker. Maybe I'll look into contributing this to the Modrinth API in the future though since it seems very useful to me, also for other API consumers.Turns out the Modrinth API docs just don't include this info ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604 by allowing the user to choose between receiving all updates, betas and releases, or only releases (default).
This branch is based on the work from #679 and I will keep this as a draft until Max's work is merged into the upstream repo.
It'd however be awesome if these two PRs could land in the same release of ModMenu so I do not have to mark the new method in the
UpdateInfointerface as being optional (and prob end up not being used a lot).