Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove dead code #843

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ryancausey
Copy link

This doesn't seem to be used anywhere.

@bsanders
Copy link
Contributor

bsanders commented Oct 8, 2020

@ryancausey thank you (I think?) for the PR. It's currently failing tests (our test ci/cd pipeline is all behind a firewall :( ).

There are tests failing that have 'firmware' in the name of the test, and there's still one test that has firmare in the name: test_sync_host_firmware.py

@ryancausey ryancausey force-pushed the bugfix/where-dreams-go-to-die branch from 9fba0d6 to cfcf667 Compare October 10, 2020 18:35
@bsanders bsanders force-pushed the bugfix/where-dreams-go-to-die branch from cfcf667 to abced2a Compare October 23, 2020 18:16
@bsanders
Copy link
Contributor

I cut out the last of it. Rebase down to one commit and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants