Skip to content

Tidy up the shutdown sequence in EnhancedAgent #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wanbogang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tidy up the shutdown sequence in EnhancedAgent #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6b7e88
Tidy up the shutdown sequence in EnhancedAgent
Dec 3, 2025
cceda4b
Merge branch 'main' into fix/shutdown-ordering
Wanbogang Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/agent/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@ func (a *EnhancedAgent) Stop() error {
log.Printf("🛑 Stopping enhanced agent: %s", a.config.Name)

a.running = false
a.cancel()

// Cancel all active tasks
a.taskCoordinator.CancelAllTasks()
Expand All @@ -368,16 +367,21 @@ func (a *EnhancedAgent) Stop() error {
log.Printf("⚠️ Error disconnecting from network: %v", err)
}


// NOW cancel the context
a.cancel()
// Close cache connection
if a.agentCache != nil {
if err := a.agentCache.Close(); err != nil {
log.Printf("⚠️ Error closing cache connection: %v", err)
}
}

// Cleanup agent handler if it supports cleanup
// Cleanup agent handler with fresh context
if cleaner, ok := a.agentHandler.(types.AgentCleaner); ok {
if err := cleaner.Cleanup(a.ctx); err != nil {
cleanupCtx, cleanupCancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cleanupCancel()
if err := cleaner.Cleanup(cleanupCtx); err != nil {
log.Printf("⚠️ Error cleaning up agent handler: %v", err)
}
}
Expand Down