fix(k8s): make helm test pods schedulable and probe CubeProxy healthz - #1388
Open
fslongjin wants to merge 1 commit into
Open
fix(k8s): make helm test pods schedulable and probe CubeProxy healthz#1388fslongjin wants to merge 1 commit into
fslongjin wants to merge 1 commit into
Conversation
Test pods that only talk to Services/the API now share cube.testPlacement (both plane taint tolerations, no nodeSelector) so they stay schedulable on control-only, compute-only, and mixed topologies. node-runtime-test keeps computePlacement and pins runAsUser 0 for hostPath sockets. proxy-control-test probes /admin/healthz; dns-test uses getent ahostsv4. Assisted-by: Cursor:Grok-4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #1272 (contributor went silent after review). Rebased onto current
masterand simplified the placement model.helm testpods that only talk to Services / the API now sharecube.testPlacement: the union of control-plane and compute taint tolerations, with no nodeSelector. That is what actually unsticks Pending pods on tainted nodes, without pinning a plane that the other topologies do not have.testPlacement(schedulable on control-only, compute-only, and mixed).computePlacement(hostPath sockets only exist on cube-node hosts). Skipped whencubeNode.enabled=false. PinsrunAsUser: 0/runAsGroup: 0so a non-root image override cannot silently failstat()./admin/healthzwithX-Cube-Admin-Tokenfrom the release Secret; capture curl exit; assert HTTP 200. No--retry-all-errors.helmTest.image(curlimages/curl) +getent ahostsv4with retries and diagnostics.helmTest.dnsImagestays busybox for node-runtime-test only.Addresses the #1272 review blockers: missing
runAsUser: 0, overstated topology claims,health-testPending on control-only,cubemastercli-testPending on compute-only.Original probe/DNS diagnosis is from #1272 (@try-agaaain).
Test plan
helm lint+deploy/kubernetes/chart/scripts/test-helm-test-guards.sh(default,cubeNode.enabled=false, compute-onlyexternalControlPlane,values-single-node.yaml)helm teston a control-plane-tainted single-node cluster withvalues-single-node.yamlhelm teston a multi-node cluster with compute nodesAssisted-by: Cursor:Grok-4.6
Made with Cursor