cubemaster: fix the data races in localcache #1376
+265
−30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // Copyright (c) 2024 Tencent Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| package localcache | ||
|
|
||
| import ( | ||
| "context" | ||
| "sync" | ||
| "sync/atomic" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestConcurrentGetAndRefreshOnSameKey(t *testing.T) { | ||
| var loads int64 | ||
| localCache := NewCache("race-probe", | ||
| func(ctx context.Context, key string) (interface{}, bool, error) { | ||
| atomic.AddInt64(&loads, 1) | ||
| return RandString(16), true, nil | ||
| }, | ||
| &LocalCacheConfig{ | ||
| LowCacheSize: 1000000, | ||
| HighCacheSize: 2000000, | ||
| Expired: time.Millisecond, | ||
| AsyncRefreshBefore: time.Millisecond, | ||
| MaxAsyncRefreshNum: 100, | ||
| ExpiredUse: true, | ||
| }) | ||
| defer localCache.Destroy() | ||
|
|
||
| ctx := context.Background() | ||
| const readers = 32 | ||
| const iterations = 300 | ||
|
|
||
| var wg sync.WaitGroup | ||
| wg.Add(readers) | ||
| for i := 0; i < readers; i++ { | ||
| go func() { | ||
| defer wg.Done() | ||
| for j := 0; j < iterations; j++ { | ||
| v, found, err := localCache.Get(ctx, "hot-key") | ||
| if err != nil { | ||
| t.Errorf("Get: %v", err) | ||
| return | ||
| } | ||
| if found { | ||
| if _, ok := v.(string); !ok { | ||
| t.Errorf("Get returned %T, want string; a torn interface read", v) | ||
| return | ||
| } | ||
| } | ||
| } | ||
| }() | ||
| } | ||
| wg.Wait() | ||
|
|
||
| if atomic.LoadInt64(&loads) == 0 { | ||
| t.Fatal("loader never ran; the test did not exercise the refresh path") | ||
| } | ||
| } | ||
|
|
||
| func TestDestroyIsIdempotent(t *testing.T) { | ||
| localCache := NewCache("destroy-probe", | ||
| func(ctx context.Context, key string) (interface{}, bool, error) { | ||
| return "v", true, nil | ||
| }, | ||
| &LocalCacheConfig{LowCacheSize: 1000, HighCacheSize: 2000, Expired: time.Minute}) | ||
|
|
||
| localCache.Destroy() | ||
| localCache.Destroy() | ||
| } | ||
|
|
||
| func TestConcurrentDestroyDoesNotRaceWithBackgroundLoops(t *testing.T) { | ||
| localCache := NewCache("destroy-race-probe", | ||
| func(ctx context.Context, key string) (interface{}, bool, error) { | ||
| return "v", true, nil | ||
| }, | ||
| &LocalCacheConfig{LowCacheSize: 1000, HighCacheSize: 2000, Expired: time.Minute}) | ||
|
|
||
| var wg sync.WaitGroup | ||
| wg.Add(4) | ||
| for i := 0; i < 4; i++ { | ||
| go func() { | ||
| defer wg.Done() | ||
| localCache.Destroy() | ||
| }() | ||
| } | ||
| wg.Wait() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SetupConfigdeliberately guards a nil config (if localCacheConfig == nil { return nil }), solocalCache.localCacheConfigcan be nil here and this new unconditionallocalCacheConfig.ExpiredUsedereference turns a nil config into a panic at construction time — previously the panic was deferred to the firstGeton an expired entry. No current caller passes nil, so this is latent rather than a live bug, but the new code bypasses the nil guard thatSetupConfigprovides. ConsiderlocalCache.expiredUse.Store(localCacheConfig != nil && localCacheConfig.ExpiredUse)or an explicit nil check.