docs: reorganize navigation doc - #1365
Conversation
| { text: 'Overview', link: '/dev/' }, | ||
| { text: 'Redis Key Convention', link: '/dev/redis-key-spec' } | ||
| { text: 'Redis Key Convention', link: '/dev/redis-key-spec' }, | ||
| { text: 'Blog Maintenance', link: '/guide/maintainer/blog' } |
There was a problem hiding this comment.
Minor navigation inconsistency: this moves Blog Maintenance into the /dev/ sidebar, but the page still lives at /guide/maintainer/blog — a path matched by the /guide/ sidebar prefix. When a reader clicks this link, VitePress swaps to the /guide/ sidebar on arrival, where the entry is no longer listed (the old "Maintainer Docs" group was removed in this PR). The page becomes orphaned: reachable, but never visible or highlighted in the sidebar that's actually shown. Consider keeping a small "Maintainer" entry in the /guide/ sidebar (e.g. under "Operations & Reference"), or relocating the page under /dev/. The zh change (/zh/dev/ → /zh/guide/maintainer/blog) has the same issue.
| white-space: nowrap; | ||
| } | ||
|
|
||
| html[lang='zh'] .VPHomeHero .tagline { |
There was a problem hiding this comment.
Nit: html[lang='zh'] is an exact match on the <html lang> attribute. It happens to work today because the zh home page has no lang frontmatter and inherits lang: 'zh' from the locale config — but every other zh doc page sets lang: zh-CN (e.g. docs/zh/guide/integrations/claude-code.md). If the home page ever gains lang: zh-CN for consistency, this rule silently stops matching and the Chinese tagline wraps again. html[lang^='zh'] would be more robust.
Review: docs: reorganize navigation doc (#1365)AI-generated review — no human approval implied. Verdict: Approve with minor nits. This is a clean docs reorganization. The sidebar/nav restructure for both locales is well-executed and I found no broken links, no lost content, and no structural problems in the VitePress config. What I verified against the base tree
Findings
Notes (non-blocking)
|
a74d8b9 to
b831866
Compare
b831866 to
7767722
Compare
reorganize the bilingual guide sidebar by topic Signed-off-by: kamilu <kamilu@tencent.com>
7767722 to
ba343be
Compare
| }, | ||
| { text: 'Cube 100 Program', link: '/guide/cube100' }, | ||
| { text: 'Integrations', link: '/guide/integrations/' } | ||
| { text: 'Overview', link: '/guide/troubleshooting/' }, |
There was a problem hiding this comment.
Nit: the group already has link: '/guide/troubleshooting/', so this Overview item is a second sidebar entry pointing at the same URL (same for the zh 排障概览). On the troubleshooting index page, two adjacent entries resolve to the same route and can both render active. Consider dropping the redundant Overview item and keeping the group link (or vice versa).
| /* Keep the Chinese home-page tagline on one line when the viewport has room. | ||
| Narrow screens retain VitePress's responsive wrapping behavior. */ | ||
| @media (min-width: 768px) { | ||
| .VPHomeHero .text { |
There was a problem hiding this comment.
Nit: this .text rule is unscoped and applies the nowrap to the hero title in both locales, even though the comment above says the intent is the Chinese tagline (only the .tagline rule below is scoped with html[lang^='zh']). Combined with min-width: 768px, a longer title or tagline could overflow without wrapping on tablet-width screens. Consider scoping this rule to html[lang^='zh'] too, or keeping the default wrapping above a generous max-width.
reorganize the bilingual guide sidebar by topic