Skip to content

Conversation

@RylanBot
Copy link
Collaborator

@RylanBot RylanBot commented Oct 10, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

https://stackblitz.com/edit/kqqkg61k?file=src%2Fdemo.tsx

💡 需求背景和解决方案

(与 Tree 的 UI 交互保持一致)

📝 更新日志

  • fix(Select): 修复开启 multiple 时,disabled 的选项依旧能被删除的问题

  • fix(Select): 修复 disabled 且被选中的选项会被 checkAll 修改状态的问题

  • fix(Select): 修复存在 disabled 项时,checkAll 可选框的 checkedindeterminate 状态不合理的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 10, 2025

tdesign-react-demo

npm i https://pkg.pr.new/tdesign-react@3879

commit: bc0d1c0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

完成

@RylanBot RylanBot added the WIP work in porgess label Oct 10, 2025
@RylanBot RylanBot removed the WIP work in porgess label Oct 10, 2025
@RylanBot RylanBot requested a review from Copilot October 10, 2025 12:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes multiple bugs related to the Select component's behavior when using the multiple and checkAll options, specifically addressing issues with disabled options being incorrectly selectable or deselectable.

  • Improves the check-all logic to properly handle disabled options by separating selectable and disabled items
  • Fixes the filter option logic to use dynamic label keys instead of hardcoded 'label' property
  • Updates the Option component to calculate selection states more accurately for check-all scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Select.tsx Refactors check-all logic to properly handle disabled options and fixes filter option to use dynamic label key
PopupContent.tsx Updates selectedValue filtering for checkAll options and passes additional props for accurate selection state
Option.tsx Enhances selection state calculation by distinguishing between selectable and total selected lengths

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RylanBot RylanBot added the WIP work in porgess label Oct 15, 2025
@RylanBot RylanBot changed the title fix(Select): improve filter option logic to use dynamic label key fix(Select): optimize disabled condition check for multiple selection Oct 15, 2025
@RylanBot RylanBot requested a review from Copilot October 15, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RylanBot RylanBot removed the WIP work in porgess label Oct 15, 2025
@uyarn uyarn merged commit e92e6af into develop Oct 23, 2025
9 checks passed
@uyarn uyarn deleted the rylan/fix/select/disable branch October 23, 2025 16:28
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants