Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix android scope null when init engine exception #4167

Merged

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Jan 7, 2025

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested review from siguangli and iPel as code owners January 7, 2025 02:22
@github-actions github-actions bot added framework: android size: xs Denotes a PR that changes 0-9 lines labels Jan 7, 2025
Copy link

hippy-service bot commented Jan 7, 2025

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Jan 7, 2025

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 7, 2025
@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 7, 2025 02:25
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 7, 2025
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ etkmao
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

@siguangli siguangli disabled auto-merge January 8, 2025 02:54
@siguangli siguangli merged commit a2aab0f into Tencent:main Jan 8, 2025
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: android size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants