Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same situation as #376: this adds one file containing a single Figma URL, with no code.
The description goes further than #376 in describing implementation that isn't here — it specifies
embed.FSserving with zero external dependencies, aPLAYGROUND_ENABLED=falsegate, a pre-populatedX-API-Keyheader, and a production fallback for when introspection is disabled. Those are real backend behaviours with security implications (introspection gating in particular), and none of them are implemented in this diff.Problems:
Closes #68would auto-close an unimplemented feature. Issue feat(go-api): GraphQL Playground at /playground #68 (feat(go-api): GraphQL Playground at /playground) is open and unbuilt. Merging this closes it while delivering no endpoint.Filename
GraphQL Playground— space, no extension. Same tooling/globbing problem as Create developer dashboard — event browser UI #376.The security-relevant parts need actual code review. Introspection gating and API key handling are exactly the things that need to be reviewed as code, not as a mockup.
Please close this and move the Figma link to a comment on #68, leaving the issue open. If you want to implement it, a fresh PR with the
/playgroundhandler, thePLAYGROUND_ENABLEDgate, and tests for the disabled-in-production path would be very welcome — the design gives a clear target to build against.