Skip to content

docs: document SAC decoder test coverage and conventions #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joan-bisbal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: document SAC decoder test coverage and conventions #350

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8b99b3
test: add unit tests for SAC decoder module
joan-bisbal Jul 27, 2026
d83061c
test: add comprehensive unit test specification and edge case guide f…
joan-bisbal Jul 29, 2026
e804979
docs: document SAC decoder test coverage and conventions
joan-bisbal Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sac_decoder_unit_tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# SAC Decoder Unit Tests

Test coverage for SAC event decoding and asset symbol parsing.

@Depo-dev Depo-dev Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is test: add unit tests for SAC decoder module, but the diff contains no tests — just a three-line file describing them. A test PR needs actual #[test] functions.

The SAC decoder already has unit tests as well: crates/indexer/src/parser/sac.rs has a mod tests with 11 cases covering registry lookup and asset-context attachment, and crates/indexer/src/parser/token_events.rs covers the SEP-41 event decoding alongside it.

If you want to strengthen coverage there, the useful contribution would be additional cases against the existing module — malformed XDR, unusual asset codes, contracts that are not in the registry — as real Rust tests that run in CI. Please target dev rather than main, and drop the UTF-8 BOM on any new file.

Loading