-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce automatic session tracking & enhance default parameters (targeting main
)
#230
base: main
Are you sure you want to change the base?
Conversation
Note that this commit was manually tested in a project and confirmed to work (persist, reset & count) as expected.
@Jeehut could it be |
@kkostov Oh, my mistake, I just noticed that I mentioned the Basically, the detection of a new user could be done but would be way more complicated (and maybe not possible on other platforms) to implement & explain to developers, so we had decided to simply consider a new install as a new user, which in practice is good enough for the purposes of trend analysis. So in practice, these concepts don't differ as the new installs actually are the new users – forget about the |
Awesome, thanks! PR is open. |
This is simply the
feature/pirate-metrics
branch with all the unfinished code madeprivate
and allTODO
comments removed. The goal is to get the already-implemented and automatically sentTelemetryDeck.Acquisition.newInstallDetected
signal shipped early in the SDK so we can already provide the "New Users" insight on our Web dashboard.Note that all of the code was already approved in #225 and #223, therefore no additional review should be needed. Most of the changes here were only to make SwiftLint happy (as the
Signal
file got too long, I had to split it up).